Skip to content

Commit

Permalink
Fix CI for PRs on master (#688)
Browse files Browse the repository at this point in the history
This does three things:
1. it makes sure we explicitly use _our_ lerna, not the global one that seems to come with `ubuntu_latest` in the build step
2. it makes sure we use the storybook CLI that matches our storybook version when extracting the stories, `npx sb` would install the latest version if it is not already in node_modules
3. it updates chromatic because there was an issue with the chromatic part failing despite a change already being accept in the chromatic web interface (this PR does not touch components at all)
  • Loading branch information
micgro42 authored Aug 16, 2023
1 parent 1114e62 commit c5fb2ab
Show file tree
Hide file tree
Showing 3 changed files with 1,467 additions and 1,456 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-and-demo.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
run: npm ci
- name: Build # only runs in case of cache hit, otherwise as part of npm ci
if: steps.cache.outputs.cache-hit == 'true'
run: lerna bootstrap
run: npm run lerna bootstrap

test:
runs-on: ubuntu-latest
Expand Down
Loading

0 comments on commit c5fb2ab

Please sign in to comment.