Skip to content

Commit

Permalink
Fix bugs in C24_WMDE_Desktop_EN_05
Browse files Browse the repository at this point in the history
- UoF infographic was missing an arrow
- Add payment types to VAR submit button
- Fix font size on upgrade form
- Fix currency symbol placement in custom amount
- Fix fallback close button size

Ticket: https://phabricator.wikimedia.org/T380360
  • Loading branch information
Abban committed Nov 26, 2024
1 parent 7390a86 commit 0df52c6
Show file tree
Hide file tree
Showing 7 changed files with 33 additions and 560 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
<MastercardLogo/>
</span>
</template>

<template #button>
<MainDonationFormPaymentMethodLabeledButton/>
</template>
</MainDonationFormAddressType>
</template>

Expand Down Expand Up @@ -108,6 +112,7 @@ import SoftClose from '@src/components/SoftClose/SoftClose.vue';
import WMDEFundsForwardingEN from '@src/components/UseOfFunds/Infographics/WMDEFundsForwardingEN.vue';
import { useBannerHider } from '@src/components/composables/useBannerHider';
import MainDonationFormAddressType from '@src/components/DonationForm/Forms/MainDonationFormDonationReceipt.vue';
import MainDonationFormPaymentMethodLabeledButton from '@src/components/DonationForm/Forms/MainDonationFormPaymentMethodLabeledButton.vue';
enum ContentStates {
Main = 'wmde-banner-wrapper--main',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ $breakpoint: 800px;
width: 16px;
top: 8px;
right: 8px;
margin: 0;
padding: 0;

@media ( min-width: $breakpoint ) {
height: 30px;
Expand Down
5 changes: 3 additions & 2 deletions banners/english/C24_WMDE_Desktop_EN_05/styles/styles.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@
@use 'src/themes/Treedip/DonationForm/Forms/MainDonationForm' with (
$padding: 14px 0 0
);
@use 'src/themes/Treedip/DonationForm/Forms/UpgradeToYearlyButtonForm';
@use 'src/themes/Treedip/DonationForm/Forms/CustomAmountForm';
@use 'src/themes/Treedip/DonationForm/Forms/UpgradeToYearlyButtonForm' with (
$font-size: 14px
);
@use 'src/themes/Treedip/Footer/FooterAlreadyDonated' with (
$right-column-width: 300px
);
Expand Down
5 changes: 3 additions & 2 deletions banners/english/C24_WMDE_Desktop_EN_05/styles/styles_var.scss
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@
@use 'src/themes/Treedip/DonationForm/Forms/MainDonationFormDonationReceipt' with (
$padding: 14px 0 0
);
@use 'src/themes/Treedip/DonationForm/Forms/UpgradeToYearlyButtonForm';
@use 'src/themes/Treedip/DonationForm/Forms/CustomAmountForm';
@use 'src/themes/Treedip/DonationForm/Forms/UpgradeToYearlyButtonForm' with (
$font-size: 14px
);
@use 'src/themes/Treedip/Footer/FooterAlreadyDonated' with (
$right-column-width: 300px
);
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 0df52c6

Please sign in to comment.