This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
Support content URIs properly for uploads on Android #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sending multiple requests in the same time
createJSModules was removedin React Native 0.47.0 and results in the attached Build Error. removing @OverRide fixes build (didn't remove function because I don't know if it should be kept for downard compatability?) ``` node_modules/react-native-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobPackage.java:23: error: method does not override or implement a method from a supertype @OverRide ^ 1 error Incremental compilation of 1 classes completed in 0.219 secs. :react-native-fetch-blob:compileReleaseJavaWithJavac FAILED FAILURE: Build failed with an exception. ```
remove extra space
|
Latest 2 commits are the relevant changes |
|
FYI react-native-fetch-blob has a new maintained location. Check out the README. Please consider submitting your PR there, this repository is unmaintained. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content URIs can point to "virtual files" on Android. Rather than trying to determine an actual file path for these URIs, which may or may not exist, stream the input without a file path.
This isn't a complete PR as it focuses on uploads only. Someone will probably need to add some logic in for local file access.