Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WINDUPRULE-1037] Improves EAP 8 JSP rule, clarifying it is about Fac… #1030

Merged
merged 2 commits into from
Oct 24, 2023
Merged

[WINDUPRULE-1037] Improves EAP 8 JSP rule, clarifying it is about Fac… #1030

merged 2 commits into from
Oct 24, 2023

Conversation

emmartins
Copy link
Contributor

…es removing support for JSP, and make it potential
Issue: https://issues.redhat.com/browse/WINDUPRULE-1037

@PhilipCattanach
Copy link
Contributor

@emmartins - You need to update the wording in the test, as you've changed the message.
The test is failing with

Error with test: eap8-faces-00009-test
Cause: (Rule: eap8-faces-00009-test) Assertion failed: [eap8-faces-00009] The hint was not found!

@emmartins
Copy link
Contributor Author

emmartins commented Oct 20, 2023 •
edited
Loading

@PhilipCattanach think I need some help here, I changed the test message but it is still failing, maybe something not good with the rule itself? The idea is to catch whenever one of the 2 dependencies is present AND there is a jsp file... Other than the wrong message now fixed I don't see any issue with the test data, the pom.xml has such dependency and there is a jsp.

@emmartins
[WINDUPRULE-1037] Improves EAP 8 JSP rule, clarifying it is about Fac…
e76089b 
…es removing support for JSP, and make it potential
@emmartins
Copy link
Contributor Author

all seems good to merge, thanks for the help

@PhilipCattanach
Copy link
Contributor

Successfully tested, happy to merge. thanks @emmartins

@PhilipCattanach
Copy link
Contributor

There is an integration test that is failing beacsue of a broken link. Nothing to do with this change, so we can address that separately under https://issues.redhat.com/browse/WINDUPRULE-1039

@PhilipCattanach PhilipCattanach merged commit 99fefd4 into windup:master Oct 24, 2023
25 of 26 checks passed
@mrizzi mrizzi added auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch labels Oct 24, 2023
github-actions bot pushed a commit that referenced this pull request Oct 24, 2023
@emmartins
[WINDUPRULE-1037] Improves EAP 8 JSP rule, clarifying it is about Fac…
bd4797c 
…es removing support for JSP, and make it potential (#1030)

Co-authored-by: Phil Cattanach <31246010+PhilipCattanach@users.noreply.github.com>
(cherry picked from commit 99fefd4)
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Merged
@github-actions
Copy link

💚 All backports created successfully

Status Branch Result
✅ releases/6.3.z

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

mrizzi pushed a commit that referenced this pull request Oct 24, 2023
@github-actions @emmartins
[WINDUPRULE-1037] Improves EAP 8 JSP rule, clarifying it is about Fac…
012af62 
…es removing support for JSP, and make it potential (#1030) (#1034)

Co-authored-by: Phil Cattanach <31246010+PhilipCattanach@users.noreply.github.com>
(cherry picked from commit 99fefd4)

Co-authored-by: Eduardo Martins <emartins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-backport Set the PR for being backported auto-backport-to-releases/6.3.z Backport this issue to releases/6.3.z branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmartins @PhilipCattanach @mrizzi