Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup/renameinvalidate #118

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Fixup/renameinvalidate #118

merged 6 commits into from
Jan 2, 2024

Conversation

willscott
Copy link
Owner

simplify to remove inverse cache and directly invalidate handles

@DUOLabs333
Copy link
Contributor

This doesn't fix the problem of handles not being one-to-one/a new handle is returned every lookup.

@willscott
Copy link
Owner Author

Good point. I think we do need the complexity you suggested. I added an additional method to properly evict from the reverse index as well.

@DUOLabs333
Copy link
Contributor

Technically, the reverse cache must also hold the filesystems --- at which point, we should just use my PR.

@willscott
Copy link
Owner Author

does it?

  • if the handle matches, you can recover the filesystem from the forward cache
  • I'd prefer a single strong type rather than any for the value
  • we should be doing expiry so that the reverse cache doesn't grow in an unbounded way

@willscott willscott merged commit 9c599ee into master Jan 2, 2024
4 checks passed
@willscott willscott deleted the fixup/renameinvalidate branch January 2, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants