add book language ID fields #305
Conversation
Load data from a CSV
Set up video controller
Fix titles, fix navigation, small polish
| # only returns an ID if the verbatim search returns exactly one result | ||
| def id_check(input_lang) | ||
| # TODO do not hard-code this URL, move to a config constant | ||
| url_string = 'http://localhost:6543/search?q=' + input_lang + '&whole=true'; |
There was a problem hiding this comment.
I wasn't sure how to properly set up a config constant. Ideally this constant can be used by both the Ruby code and the React code.
There was a problem hiding this comment.
I've made the production url an environment variable on Heroku and on my local .ENV, happy to show you
| # TODO this function copied from books_controller. put in a helper class | ||
| # given an identifier string, get the language ID | ||
| # only returns an ID if the verbatim search returns exactly one result | ||
| def id_check(input_lang) |
There was a problem hiding this comment.
This function should be in a helper class, but I wasn't familiar with where this class would go or how to add a dependency to it.
baieric
changed the title
baieric
changed the title
|
Looks great! All i need in order to test this is to get a local instance of glottolog3 running. Any chance you could update the readme there with instructions on how to get it running? Got requirements installed but couldn't quite get setup.py or serve.py running. |
|
@baieric I've gone ahead and updated the url to reference an environment variable which points to the Heroku deploy of the ontology, but have started to get this error: |
|
@FredericoAndrade Do you have a typo somewhere? Sounds similar to this issue: jnunemaker/httparty#393 This PDF has setup instructions for glottolog3. You'll need to get a local DB running as well. The instructions are intended for Heroku, but if you do steps 1-4 and step 6, it should run locally. |
Update fork from Wikitongues master
These are backend changes for eventually supporting the use the Language Ontology API in Poly. Hopefully these changes can be merged immediately.
There are some
TODOcomments where the code could be cleaner. I'll add Github comments to these for visibility.There are two user-facing changes in this PR:
/search?q=<query_string>&glottocode=<glottocode_string>. Theglottocodeparameter is optional and not used currently (unless the user manually puts it in the URL). This will match all results containingquery_stringOR with language ID equal toglottocode_string. Let me know how you feel about this.are_close?function, meaning that search results will work differently. I noticed some annoying results where "English" was close to "Spanish", which seems very undesirable. I didn't play around with thedesired_distanceconstant, but maybe lowering it could fix this, rather than completely getting rid of it.