Feature/3 create react version #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 26, 2019 15:51
TODO: - Let React manage the `init` logic of `scripts/card.js` - Export logic of `scripts/card.js` for React (and other libraries)
The branch ``feature/3…` was created from an out-of-date `master`.
- Extract `react/element-input` component. - Extract `react/attribute-input` component. - Add `entity-elements` constants. - Convert HTML attribute to JSX attributes. - Add TODO comments in `react/card` component. - Pass default values to `react/card` component as props.
Also, add more constants.
…r/wesleyb-sample-wysiwyg-rpg-card-maker into feature/3-create-react-version
Also: - Rename `event` to `e`. - Fix default value typo. - Rename `Toggle` props to match `…Input`s. - Uncomment commented code in `scripts/card.js`. - Do not call `scripts/card.js` in React code.
- from `onIsActiveChange` to `onChange` - from `isActive` to `isOn`
This is redundant, but allows finding `TODO.md` when searching `TODO`
- Wrap dev scripts in container div. - Rename `typedef.jsdoc` to `typedef.js`. - Rename "attribute" properties to "attributes". - Rename `form` to `shape` in JSDoc `@typedef`. - Resolve expected temporary ESLint errors. - Make `value` optional for `select`s and numeric inputs. - Make optional the `Card` properties. - Add `placeholder` for `select`s. - Add more TODOs.
- Also, fixed JSDoc typos and moved some lines.
added 26 commits
September 30, 2019 18:29
Found no online mention; all assume that `(default)Value` should be set.
Any element using internal `onChange` must support external `onChange`
…eact-version--test-merge-feature-9
|
I back-merged and resolved conflicts. Merging, now. Then will very soon open PR to unmarry React from build process (issue #9). |
|
Do not delete this #3 feature branch, yet. Some enhancement To Do's still exist. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React and native builds are working, but the changes marry React and the build process. This will be quickly resolved by issue #9 (which is re-opened specifically for this purpose).