-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically give penalty when payment is overdue #3646
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3646 +/- ##
==========================================
+ Coverage 89.11% 89.13% +0.02%
==========================================
Files 682 683 +1
Lines 21464 21533 +69
==========================================
+ Hits 19128 19194 +66
- Misses 2336 2339 +3 ☔ View full report in Codecov by Sentry. |
5744627
to
11f50ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Currently this checks every day at 2100 if there is any events with overdue payments. If so it gives penalty to the users who have not paid, unregisters them from the event and sends notification.
This is a first draft of the consept. Future improvements should be to check if they paid after the set deadline, not just at 2100. Also the notification to the event creator could be removed if this is solution is satisfactory.
Also im not married to the names like
event_payment_overdue_penalty
i will try to think of some better, but it is conflicting with the currently existingpayment_overdue
functionalities (which is more likepayment_due
)Resolves ABA-30