When running on PhantomJS, the Object.defineProperty method doesn't w… #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork for every element, prints a log on console and doesn't throw an exception. So now it checks for the change, and forces an exception.
pedrolauro
force-pushed
the
bug-karma-phantomjs
branch
from
3e609b1
to
72b7ed9
Compare
|
Have you signed a Google Contributor License Agreement? This is one of the requirements before we can merge patches. If not, can you test if |
|
Where do I sign it, @ewilligers ? Can't find where. |
|
I tested with your forked solution, still getting error. CLA signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on PhantomJS, the Object.defineProperty method doesn't work for every element, prints a log on console and doesn't throw an exception. So now it checks for the change, and forces an exception.