Support flux 2 4 0 #4230
Open
Support flux 2 4 0 #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s for flux 2.3.0
* ci(test): bump Ginkgo and envTest versions * test: migrate TestUpdateNamespaces to Flux 2.3 * test: migrate TestGetObjectSessionObjects to Flux 2.3
casibbald
commented
Nov 25, 2024
| Expect(dashboardType).To(Equal(DashboardTypeEnterprise)) | ||
| Expect(dashboardName).To(Equal("dashboard-3")) | ||
| }) | ||
| // It("returns the oss dashboard type if the dashboard is installed with a helmrelease", func() { |
There was a problem hiding this comment.
@erikgb These seem to be the last remaining items to get this merged
There was a problem hiding this comment.
Nice @casibbald! Should I take a look tonight?
|
Yes feel free. Will also give it ago this evening
…On Mon, 25 Nov 2024 at 14:45, Erik Godding Boye ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/run/install/install_dashboard_test.go
<#4230 (comment)>
:
> - })
- Expect(err).ToNot(HaveOccurred())
- Expect(dashboardType).To(Equal(DashboardTypeEnterprise))
- Expect(dashboardName).To(Equal("dashboard-3"))
- })
-
- It("returns the enterprise dashboard type if both dashboards are installed with a helmrelease", func() {
- dashboardType, dashboardName, err := GetInstalledDashboard(fakeContext, fakeClientWithHelmReleases, testNamespace, map[DashboardType]bool{
- DashboardTypeOSS: true,
- DashboardTypeEnterprise: true,
- })
- Expect(err).ToNot(HaveOccurred())
- Expect(dashboardType).To(Equal(DashboardTypeEnterprise))
- Expect(dashboardName).To(Equal("dashboard-3"))
- })
+ // It("returns the oss dashboard type if the dashboard is installed with a helmrelease", func() {
Nice @casibbald <https://github.com/casibbald>! Should I take a look
tonight?
—
Reply to this email directly, view it on GitHub
<#4230 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6C36EOZXUI7RHOGRF5MT2CMLYHAVCNFSM6AAAAABSNU6EMWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINJYGM2DAMBXGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
Why was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes