fix:unknown NoData state option for alertrulev9 #606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kamilswiec <kamilswiec@protonmail.com>
kamilswiec
force-pushed
the
fix/no_data_state_alertrulev9
branch
from
2c18981
to
98e036e
Compare
kamilswiec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Fixes problem with AlertRuleV9
unknown NoData state option No Data. Details here: #601Why is it a good idea?
It covers important part of alert rule configuration.
Context
I've run into the same issue as: #601.
Found correct value here: https://github.com/grafana/grafana/blob/6393ef93857d33073147d7f6ee73dcc976d40c25/pkg/services/ngalert/models/alert_rule.go#L62C5-L62C5.
Tested it with Grafana version
9.5.2Questions
I assume we do not want to reuse variables and rather point them out explicitly but not sure about it.