Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zach - Submission - tunr_express #168

Open
wants to merge 47 commits into
base: master
Choose a base branch
from

Conversation

zachariah-chow
Copy link

@zachariah-chow zachariah-chow commented Apr 17, 2020

Deliverable Submission

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5): 4

Completeness Level (1-5): 2

How many hours did you spend on this assignment?: 4

What part did you spend the most time on?

Troubleshooting Postgres --> had an issue especially while adding styles, where I would refresh a page many times, resulting in multiple new connections/queries being made. This then leads to the error:- "psql: FATAL: sorry, too many clients already". **Turns out there was a connection leak where clients were not released back to the pool.

Does the assignment run without errors? If the assignment has errors, what are they?

The code runs without errors. The UI is clumsy.

Describe one part of the code or choose one line you would improve upon. What would you improve?

Styles. Complete my controllers and views.

What did you think of this deliverable? Any other comments?

util/database.js Outdated Show resolved Hide resolved
@zachariah-chow
Copy link
Author

Part II

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5): 4

Completeness Level (1-5): 3

How many hours did you spend on this assignment?: At least 10 hours by now

What part did you spend the most time on?

Queries for playlists routes. Thinking of how much I need to get out of each query, and the best way to deal with the query results.

Does the assignment run without errors? If the assignment has errors, what are they?

Yes, although there are probably UI bugs due to loose input validation

Describe one part of the code or choose one line you would improve upon. What would you improve?

Some of the queries are convoluted, especially in the playlist routes. Cut some corners by using custom HTML attributes, which adds to some source confusion regarding data. Refactoring for playlist routes required.

What did you think of this deliverable? Any other comments?

A good microcosm of how a server interfaces with a backend, I think. Also, much needed SQL practice.

@zachariah-chow
Copy link
Author

Part 2.5

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5): 4

Completeness Level (1-5): 2

How many hours did you spend on this assignment?

About 3 hours on this part

What part did you spend the most time on?

Reading up about cookies and sessions.

Does the assignment run without errors? If the assignment has errors, what are they?

Not fully tested cookie functionality, but seems to work for now.

Describe one part of the code or choose one line you would improve upon. What would you improve?

Use a db for user information.

What did you think of this deliverable? Any other comments?

@zachariah-chow
Copy link
Author

Part 3

Deliverable Submission

Please describe your comfort and completeness levels before submitting. Comfort Level (1-5): 4

Completeness Level (1-5): 2

How many hours did you spend on this assignment?: 4

What part did you spend the most time on?

Debugging

Does the assignment run without errors? If the assignment has errors, what are they?

Think so.

Describe one part of the code or choose one line you would improve upon. What would you improve?

Refactoring controllers, models.

What did you think of this deliverable? Any other comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants