Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vimeo/psalm, update to phpunit 7.x, change require-dev to require… #22

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add vimeo/psalm, update to phpunit 7.x, change require-dev to require… #22

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68d385d
add vimeo/psalm, update to phpunit 7.x, change require-dev to require…
DavidGoodwin Dec 26, 2020
747ff9f
update travis php versions
DavidGoodwin Jan 9, 2021
c296d7e
merge origin/master
DavidGoodwin Jan 9, 2021
f77f4e6
drop php 5.6
DavidGoodwin Jan 9, 2021
5c661ae
change mikey179/vfsstream version spec
DavidGoodwin Jan 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
language: php
php:
- 7.4
- 7.2
- 5.6
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can i also ask to drop php5.6 from travis-ci?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- 5.5
- 5.4
- 5.3

install:
- composer install
Expand Down
10 changes: 8 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,14 @@
"php": ">=5.3.3"
},
"require-dev": {
"phpunit/phpunit": "~4",
"mikey179/vfsstream": "1.4.*"
"php": ">=7.2",
"phpunit/phpunit": "~7",
"mikey179/vfsstream": "1.4.*",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you upgrade to the latest 1.6.*?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done (changed to ^1.4)

"vimeo/psalm" : "*"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you drop this dependency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psalm is a dev only dependency - it won't affect users of the package.

it will help make sure you've not added errors into the codebase (E.g. wrong parameters, missing parameter, incorrect doc types etc).

},
"scripts": {
"psalm" : "@php vendor/bin/psalm",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you drop this script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding it helps the code quality. I don't see why you'd want to drop it.

Normal users of the package will not install psalm as a dependency.

"test" : "@php vendor/bin/phpunit tests"
},
"autoload": {
"psr-0": {
Expand Down
Loading