Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump readline to 0.1.0-rc1 #846

Merged
merged 1 commit into from
Jan 5, 2024
Merged

bump readline to 0.1.0-rc1 #846

merged 1 commit into from
Jan 5, 2024

Conversation

slingamn
Copy link
Contributor

@slingamn slingamn commented Jan 5, 2024

ircdog PR here: ergochat/ircdog#47

Excited for this! Are you seeing anything unexpected in testing? Have you been testing on Windows? (I did some Windows testing but I should probably do some more before the release.)

@wader
Copy link
Owner

wader commented Jan 5, 2024

Hey, great! no haven't tested myself (i should really get a windows setup!) but i asked a guy who uses fq on windows here #842 (comment) and it seems to be ok. Is there some specific areas your more worried about breaking on windows?

btw any opinion if fq should follow the master branch or stay with tagged releases?

@slingamn
Copy link
Contributor Author

slingamn commented Jan 5, 2024

I'd say tags unless there is a specific hotfix you want to pull in...generally my workflow is to do a final testing pass on release candidates before shipping them, so master is less tested.

Also I'm hoping that we need to do relatively little development work on the library going forward :-)

@wader
Copy link
Owner

wader commented Jan 5, 2024

I'd say tags unless there is a specific hotfix you want to pull in...generally my workflow is to do a final testing pass on release candidates before shipping them, so master is less tested.

👍

Also I'm hoping that we need to do relatively little development work on the library going forward :-)

Agree, it seems to work fine and i don't i have any urgent features. Only thing i can think of now is chzyer/readline#212 that would be interesting but no way urgent.

@wader wader merged commit ae06aec into wader:master Jan 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants