Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge @foxglove/avl into avl #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhurliman
Copy link

Here is a work in progress PR to merge https://github.com/foxglove/avl into this repo. There are a few important differences to review:

  • The extensive unit tests have been replaced with a more succint set of tests. I think it would be nice to preserve the existing tests, but they would need to be ported to Typescript + Jest.
  • The API has changed to only expose TS/JS primitives instead of internal node references. This avoids existing bugs in the library, but the change is debatable
  • Support for duplicate keys has been removed. This was to simplify the implementation in @foxglove/avl which did not need to support duplicate keys, but it might be important to add that support back before merging upstream.
  • Some methods with O(n) performance have been removed, and some additional query methods have been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant