Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY FOR REVIEW] Simplified Chinese - Developing for Web Accessibility #919

Merged
merged 17 commits into from
Nov 26, 2024
Merged

[READY FOR REVIEW] Simplified Chinese - Developing for Web Accessibility #919

merged 17 commits into from
Nov 26, 2024

Conversation

heybran
Copy link
Contributor

@heybran heybran commented Oct 22, 2024 •
edited by remibetin
Loading

@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

✅ Deploy Preview for wai-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a4f3e7
🔍 Latest deploy log https://app.netlify.com/sites/wai-website/deploys/67454b11ff52f10008a9b3fa
😎 Deploy Preview https://deploy-preview-919--wai-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 92 (🔴 down 8 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@heybran heybran changed the title [IN-PROGRESS] - Translation for Developing for Web Accessibility (zh-hans) [IN-PROGRESS] - Simplified Chinese - Developing for Web Accessibility Oct 22, 2024
@heybran heybran changed the title [IN-PROGRESS] - Simplified Chinese - Developing for Web Accessibility [READY FOR REVIEW] Simplified Chinese - Developing for Web Accessibility Oct 22, 2024
@heybran
Copy link
Contributor Author

heybran commented Oct 22, 2024

w3c/wai-translations#248

@heybran heybran mentioned this pull request Oct 22, 2024
Closed
2 tasks
@remibetin remibetin self-assigned this Oct 22, 2024
@heybran
Copy link
Contributor Author

heybran commented Oct 25, 2024

Preview link: https://deploy-preview-919--wai-website.netlify.app/tips/developing/zh-hans

@remibetin
Copy link
Member

@ruoxiran Thanks for accepting to review this translation!

Guidance is available at https://www.w3.org/WAI/about/translating/reviewing/

JinMokai
JinMokai reviewed Nov 16, 2024
View reviewed changes
Copy link
Contributor

@JinMokai JinMokai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @heybran
Some inappropriate terminology and some untranslated content in translations
If there are any questions, you can leave me a mesage

collections/_tips/developing.zh-hans.md Outdated Show resolved Hide resolved
collections/_tips/developing.zh-hans.md Outdated Show resolved Hide resolved
collections/_tips/developing.zh-hans.md Outdated Show resolved Hide resolved
collections/_tips/developing.zh-hans.md Outdated Show resolved Hide resolved
heybran and others added 4 commits November 17, 2024 10:04
@heybran @JinMokai
Update collections/_tips/developing.zh-hans.md
6c0e95b 
Co-authored-by: JinKai <59952672+JinMokai@users.noreply.github.com>
@heybran @JinMokai
Update collections/_tips/developing.zh-hans.md
2b027c7 
Co-authored-by: JinKai <59952672+JinMokai@users.noreply.github.com>
@heybran @JinMokai
Update collections/_tips/developing.zh-hans.md
3d0ff13 
Co-authored-by: JinKai <59952672+JinMokai@users.noreply.github.com>
@heybran @JinMokai
Update collections/_tips/developing.zh-hans.md
0b99716 
Co-authored-by: JinKai <59952672+JinMokai@users.noreply.github.com>
@heybran
Copy link
Contributor Author

heybran commented Nov 17, 2024

Thanks for reviewing @JinMokai, your suggestions have been commited.

@JinMokai
Copy link
Contributor

Thanks for reviewing @JinMokai, your suggestions have been commited.

Nice, it looks good! I will approved review!

@ruoxiran
Copy link
Contributor

Looks good to me, thank you all!

@remibetin
Copy link
Member

Thanks very much @JinMokai and @ruoxiran for reviewing @heybran's translation!

I will do some final checks before publication.

@remibetin remibetin assigned heybran and unassigned remibetin Nov 18, 2024
@heybran
Copy link
Contributor Author

heybran commented Nov 22, 2024

@remibetin, ready for final review.

@remibetin
Copy link
Member

@heybran Would you also please add @JinMokai to the contributors list?

@heybran
Copy link
Contributor Author

heybran commented Nov 26, 2024

@remibetin, the contributors list has been updated and two translations have been updated as well.

@remibetin remibetin merged commit 956553f into w3c:main Nov 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remibetin remibetin remibetin requested changes

@JinMokai JinMokai JinMokai approved these changes

@ruoxiran ruoxiran ruoxiran approved these changes

Assignees

@heybran heybran

Labels
tips translations
Projects
WAI Translations
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Simplified Chinese] Developing for Web Accessibility – Tips for Getting Started
4 participants
@heybran @remibetin @JinMokai @ruoxiran