Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VPC 2.0 #389

Merged
merged 9 commits into from
Sep 7, 2023
Merged

Add VPC 2.0 #389

merged 9 commits into from
Sep 7, 2023

Conversation

ogawa0071
Copy link
Contributor

Description

Add VPC 2.0.
VKE now automatically creates VPC 2.0. So VPC 2.0 is important to manage with Terraform.

Ref: vultr/govultr#261

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@ogawa0071 ogawa0071 changed the title Add vpc2 Add VPC 2.0 Aug 11, 2023
@ogawa0071 ogawa0071 mentioned this pull request Aug 11, 2023
Closed
@ogawa0071
Copy link
Contributor Author

@optik-aper I have fixed the issue you pointed out 👍

@optik-aper
Copy link
Member

@ogawa0071 Thank you! I've got a few more things I've encountered while testing which I'll add when I've completed testing all the different resources. Sorry it has taken so long!

optik-aper
optik-aper requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs some updates before we can merge it (see comments). The computed fields are breaking read functionality when updating after attaching VPC2 IDs to bare metal and instances.

vultr/data_source_vultr_bare_metal_server.go Outdated Show resolved Hide resolved
vultr/data_source_vultr_instance.go Outdated Show resolved Hide resolved
vultr/instances.go Outdated Show resolved Hide resolved
vultr/instances.go Outdated Show resolved Hide resolved
vultr/resource_vultr_bare_metal_server.go Outdated Show resolved Hide resolved
vultr/resource_vultr_instance.go Outdated Show resolved Hide resolved
vultr/resource_vultr_instance.go Outdated Show resolved Hide resolved
vultr/resource_vultr_vpc2.go Show resolved Hide resolved
@ogawa0071
Copy link
Contributor Author

@optik-aper Fixed 👍

@optik-aper optik-aper self-requested a review September 7, 2023 18:19
optik-aper
optik-aper approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the effort on this!

@optik-aper optik-aper merged commit a41ba52 into vultr:master Sep 7, 2023
3 checks passed
@optik-aper optik-aper mentioned this pull request Sep 21, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper optik-aper approved these changes

Assignees
No one assigned
Labels
dependencies enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogawa0071 @optik-aper @christhemorse