Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot - only security updates #69

Merged
merged 2 commits into from
May 14, 2024

Conversation

BaderBC
Copy link
Member

@BaderBC BaderBC commented May 13, 2024

image

The only reason to update libraries in our situation is to avoid using deprecated or vulnerable dependencies.
I don't like idea of that many (10) useless pull requests.

@BaderBC BaderBC requested a review from maxidragon May 13, 2024 15:40
Copy link
Member

@maxidragon maxidragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure, but this probably won't work. You are blocking all dependabot PR's, including security updates. Instead, we should delete dependabot.yml file and enable security updates in repository settings

Copy link
Member

@cooligus cooligus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try then

Copy link
Member

@cooligus cooligus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind @maxidragon knew what he said
image

@maxidragon maxidragon merged commit 83b48a7 into main May 14, 2024
1 check passed
@maxidragon maxidragon deleted the dependabot-only-security-updates branch May 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants