feat: Issue #425 - Add default "Link Actor Data" for Characters #445
Conversation
Add default "Link Actor Data" to new Actor's prototypeToken if it's type is character and is not from a Compendium. Also provided two extra options which would be sane but do not cover the Issue, so commented out.
|
Any chance you could add some testing for this? |
|
Sure. Just working on #424 at the mo.. so might be a little bit. |
|
I've added tests.. but i'm not sure how this project runs them, sorry if i'm being dumb. |
Stew-rt
changed the title
|
Not a problem! The Foundry ecosystem is just weird :) You'll want to pick up the Quench module. That'll run tests for you. |
|
Finally got tests for the 3 features working. Also, I had to have my test clean some stuff up after, as Quench doesn't seem to remove Compendiums created during a test routine. |
sets FormApplication option, submitOnClose to false. commented out function override, close() as it is undesirable.
* sets FormApplication option, submitOnClose to false. * migrated Gather scores to _onSubmit override * Added default to data.roll.type check in helpers-dice.js, setting isSuccess AND isFailure to false. * set data object in call to OseDice.Roll to not provide type Object.
There was a problem hiding this comment.
Sorry, I ran into some issues with the current changeset
Current code changes the state of a character actor from unlinked to linked when it is copied from a world to a compendium. I would call this unexpected behavior. I believe you could rather check if there is a source.id flag before changing the setting, because if there is, it means the user likely wants the token "as-is" without a mutation
There's an additional issue: when duplicating a token, sometimes* the copy is mutated to have Link Actor Token enabled. I believe a token copy should be an exact copy, and that this is also unexpected behavior
- Note: for some odd reason the sourceId is not the token being duplicated. The sourceId is the same as the duplicated token. This means that sometimes it doesn't provide what I think is unexpected behavior, if the original token was copied from a compendium. I'll raise this with Foundry, because I think a token copy should have its sourceId flag set to the duplicated token. I don't yet know another way to check if a token is a duplicate
|
Ironically, this implementation is robbed almost verbatim from the official DnD5 system, as my familiarity with the foundry base is limited. But fair do's, I'll take another look around and try again. 🙂 |
|
5e? Who plays that? 😆 Great, thanks, no rush obviously! |
|
Just leaving this here for us to monitor foundryvtt/foundryvtt#9567 |
|
Noting that the bugged behavior blocking this issue is still awaiting V12 (unless someone finds a better solution, but likely the linked issue above will lead to the best way of solving it) |
|
Noting that the bugged behavior blocking this issue is still awaiting V12 (it has been pushed several times now) |
Add default "Link Actor Data" to new Actor's prototypeToken if it's type is character and is not from a Compendium. Also provided two extra options which would be sane but do not cover the Issue, so commented out.