Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Advanced Fantasy Race and Multiclass Optional Rules #136

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

arcos
Copy link
Contributor

@arcos arcos commented Mar 4, 2022

I asked for this feature and got impatient (and amazingly! had some time to hack at it).
So I implemented races and multiclassing, which I think are the main differences between Classic Fantasy and Advanced Fantasy.

image

@arcos arcos changed the title Adds multiclassing and races to the character sheet Feature: Advanced Fantasy Race and Multiclass Optional Rules Mar 4, 2022
@anthonyronda
Copy link
Member

Hi Andrea, thanks for your pull request! I’d love to accept it right away, but there will be a delay due to having to check with Necrotic Gnome as to whether non-SRD character sheet features abide with their trademark license. We’ve already been given one special exception, and I’d rather not take too much advantage of this generosity.

@anthonyronda
Copy link
Member

There may also be design considerations (see #97) and party sheet considerations (users expecting this to work with the XP-granting feature of the party sheet)

@arcos
Copy link
Contributor Author

arcos commented Mar 4, 2022

Necrotic Gnome should be fine with this, but I think you are right we should give Gavin a chance to respond. We aren't reproducing any of his content, just implementing rules that he himself repackaged from WOTC/TSR. Let me look at #97 and the party sheet to improve on what I've done so far.

@arcos
Copy link
Contributor Author

arcos commented Mar 4, 2022

@anthonyronda I added the party overview xp dispersal support, the design I guess depends on the new code to support that design. Is that an open PR?

@anthonyronda
Copy link
Member

The design is a branch but the implementation is far from done!

If you're on Discord, the Unofficial OSE on Foundry VTT Discord server is where I'm communicating with the Designer outside of Figma comments (the thread is public). Join if you'd like! https://discord.gg/thab6fGV

@anthonyronda anthonyronda linked an issue Mar 14, 2022 that may be closed by this pull request
@mummson
Copy link

mummson commented Mar 28, 2022

@arcos Couldn't this be done as a separate addon module for this system? wouldn't that solve the problem if Necrotic Gnome wouldn't want this as a feature to the game system?

@IGALEGOI
Copy link
Contributor

Would it be interesting to add fields like HP and HD separately for each class? That allows you to write down the HP per class, as well set the hit dice per class, to roll the HD according to the amount of classes: HD/2 or HD/3.

@anthonyronda
Copy link
Member

We're still treating this PR as "pending a decision from Necrotic Gnome."

Gavin is aware we'd like to merge it while keeping the Old-School Essentials trademark exception they've given us. He doesn't need any prodding about this request specifically, though telling NG in general that you'd like official stuff on Foundry is ok.

@anthonyronda anthonyronda added this to the 1.6.4 milestone Sep 1, 2022
@anthonyronda anthonyronda removed this from the 1.6.4 milestone Sep 30, 2022
@anthonyronda anthonyronda added this to the 2.0.0 milestone Apr 6, 2023
@SamJulson
Copy link

Hi! Hate to revive an issue but I was wondering if this has had an update, considering I was also ready to implement this feature. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Advanced Fantasy Optional Rules
5 participants