-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReadSMS PDU (working) and readSMS from szotsaki but not working with SIM800L Revision:1418B05SIM800L24 #545
Open
pnb990
wants to merge
46
commits into
vshymanskyy:master
Choose a base branch
from
pnb990:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Placing "MessageStorageType" to SIM800.h (and not in Common.h) because type set isn't the same between SIMComs's implementation and 3GPP TS 27.005 V9.0.0 (p. 32).
AT+CMGDA is a SIMCom AT extension, therefore its control structure goes into SIM800.h file.
AT+CMGF and AT+CSDH work only when SIM is inserted. Otherwise they return with ERROR. * One second delay is needed for the modem to initialise SIM card properly for CMGF. Otherwise the following error message is printed: "CME ERROR: SIM busy". * CSDH needs the SMS subsystem to be initialised. Before this the following error message is printed: "CMS ERROR: operation not allowed". SMS subsystem init requires more time than 1 second (about 5 seconds) so this is why we only have one waitResponse() call and not an other delay() with 1 second.
A recent SIM card can hold up to 20 SMS messages and a SIM800C an additional 50, so a total of 70 is way below of uint8_t's 255.
CLIP: Calling Line Identification Presentation It's worth knowing who is calling besides we are being called on.
SIM MSISDN and FDN ("ON" and "FD" storage types) are deliberately not handled since they are rarely used and for the latter PUK2 input handling is also needed.
SIM MSISDN and FDN ("ON" and "FD" storage types) are deliberately not handled since they are rarely used and for the latter PUK2 input handling is also needed.
Special GSM characters which needed to be escaped (double quote, backslash, bell, and GSM NULL) are not handled since they are rare and would require more program space.
Special GSM characters which needed to be escaped (double quote, backslash, bell, and GSM NULL) are not handled since they are rare and would require more program space.
TINY_GSM_PHONEBOOK_RESULTS can be overridden by the user
Also provide a function which changes between character sets to avoid duplication and reduce code size.
Extending with phonebook-related information
According to documentation ATH max response time is 20 seconds.
Use data mode instead of text mode to be able to send any content such as raw binary. This will allow us to use TinyGSM with ArduinoBearSSL and ArduinoMqtt. It should be noted that for an unclear reason GSM_NL must be set to '\n' instead of '\r\n' to avoid "CME ERROR: operation not supported" in this mode with the Monarch GMS01Q. Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
…aki_master * remotes/szotsaki/master: (26 commits) Do not require a C++14 feature (since it's not yet enabled in Arduino platform) Adapt README file to the current upstream/master Add NETLIGHT control support for SIM800 series Add an optional parameter to callNumber() how much time it should block Adjust ATH waiting time Update README.md Update README.md Extend README Adding TINY_GSM_NO_GPRS guards to save space Documentation fix Change all phonebook-related functions to GSM alphabet Implement search in phonebook function Implement function for reading a phonebook entry Implement functions for adding and removing phonebook entries Implement functions for adding and removing phonebook entries Add phonebook storage selector and getter functions for SIM800 Add phonebook storage selector and getter functions for SIM800 Add function to turn on CLIP unsolicited messages on incoming calls Cut back SMS indices to 0..255 Issue CMGF and CSDH only when SIM inserted and add delay ...
* remotes/origin/tmp/szotsaki_master: (26 commits) Do not require a C++14 feature (since it's not yet enabled in Arduino platform) Adapt README file to the current upstream/master Add NETLIGHT control support for SIM800 series Add an optional parameter to callNumber() how much time it should block Adjust ATH waiting time Update README.md Update README.md Extend README Adding TINY_GSM_NO_GPRS guards to save space Documentation fix Change all phonebook-related functions to GSM alphabet Implement search in phonebook function Implement function for reading a phonebook entry Implement functions for adding and removing phonebook entries Implement functions for adding and removing phonebook entries Add phonebook storage selector and getter functions for SIM800 Add phonebook storage selector and getter functions for SIM800 Add function to turn on CLIP unsolicited messages on incoming calls Cut back SMS indices to 0..255 Issue CMGF and CSDH only when SIM inserted and add delay ...
Add ReadSMSPDU (ok) you can use https://github.com/mehul-m-prajapati/gsm-pdu-decoder to decode it Add ReadSMSTEXT (not working upto now)
TinyGsmClientSequansMonarch.h: use data mode
Signed-off-by: Sara Damiano <sdamiano@stroudcenter.org>
* 'master' of github.com:pnb990/TinyGSM: (31 commits) Add streamGetAtValue Add ReadSMSPDU (ok) you can use https://github.com/mehul-m-prajapati/gsm-pdu-decoder to decode it Add ReadSMSTEXT (not working upto now) backup fix missing } ignore vim temp file Add charset Option in sendSMS function Do not require a C++14 feature (since it's not yet enabled in Arduino platform) Adapt README file to the current upstream/master Add NETLIGHT control support for SIM800 series Add an optional parameter to callNumber() how much time it should block Adjust ATH waiting time Update README.md Update README.md Extend README Adding TINY_GSM_NO_GPRS guards to save space Documentation fix Change all phonebook-related functions to GSM alphabet Implement search in phonebook function Implement function for reading a phonebook entry Implement functions for adding and removing phonebook entries Implement functions for adding and removing phonebook entries ...
Example on how to use the read sms feature please. I can't get the receiveNewSMSIndication to work properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.