Skip to content

Commit

Permalink
Merge pull request #221 from voxpupuli/hiera
Browse files Browse the repository at this point in the history
mention VPT for `tests-fail` label
  • Loading branch information
bastelfreak authored Aug 9, 2020
2 parents e642a5c + 74ac03e commit e61e99b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion _docs/reviewing_pr.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ one of our modules:
* Are updates to the README.md needed but missing? Label it with `needs-docs`
* Has the file documented params or examples in the header? This needs to be updated as well
* Are there merge conflicts? You don't need to do anything. Our [Vox Pupuli Tasks GitHub App][vpt] will label this as `merge-conflicts` and notify the author
* Does it have failing tests? You don't need to do anything. Our [Vox Pupuli Tasks GitHub App][vpt] will label this as `tests-fail` and notify the author
* Were changes to master merged that are required in this PR (for example an updated Travis-CI configuration)? Add the `needs-rebase` label
* Does it need additional tests? Add the `needs-tests` label
* Does it have failing tests? Add the `tests-fail` label
* Does it drop support for a specific Operating system or a major Puppet version? Add the `backwards-incompatible` label
* Are new parameters introduced? They must have datatypes
* Are facts used? They should only be accessed via `$facts[]` or [fact()](https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/REFERENCE.md#fact) function from stdlib, but not topscope variables
Expand Down

0 comments on commit e61e99b

Please sign in to comment.