-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Graph support #15
Open
bastelfreak
wants to merge
3
commits into
voxpupuli:master
Choose a base branch
from
bastelfreak:graph
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
# frozen_string_literal: true | ||
|
||
class Forge | ||
def self.user | ||
@user ||= begin | ||
PuppetForge.user_agent = 'vox-pupuli-tasks' | ||
PuppetForge::User.find('puppet') | ||
end | ||
end | ||
|
||
def self.module(query) | ||
# this should never find two modules. | ||
# It will find zero modules if we never did a release | ||
# returns `nil` if zero | ||
@module ||= @user.modules.where(query: query).first | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
# frozen_string_literal: true | ||
|
||
# a module represents a release on https://forge.puppet.com/ | ||
class Module < ApplicationRecord | ||
belongs_to :repository | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,7 @@ class Repository < ApplicationRecord | |
primary_key: :github_id, | ||
foreign_key: :gh_repository_id, | ||
inverse_of: :repository) | ||
has_one :module | ||
|
||
## | ||
# Checks if the given Repository name is in our application scope (a module) | ||
|
@@ -76,4 +77,13 @@ def update_pull_requests(only_open: false) | |
|
||
pull_requests.count | ||
end | ||
|
||
def update_forge_module | ||
# we should save the json in Redis and cache it | ||
content = Github.client.contents("voxpupuli/#{name}", path: 'metadata.json', query: { ref: 'master' }) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue found: Line is too long. [106/100] |
||
metadata = content[:content] | ||
module_name = JSON.load(Base64.decode64(metadata))['name'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Issue found: Prefer |
||
# somehow save the result from the following lib in the module model | ||
Forge.module(module_name) | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue found: Specify a
:dependent
option.