Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasource absent #266

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Datasource absent #266

wants to merge 2 commits into from

Conversation

phil-morrell-hmlr
Copy link

wildfly::datasources::datasource doesn't pass on an ensure attribute to wildfly::resource

support ensure => absent for datasource

  • don't enable for absent configuration

A future enhancement could add ensure -> disabled to keep the configuration around.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.385% when pulling c40a6e5 on phil-morrell-hmlr:datasource-absent into d9433d4 on biemond:master.

@coveralls
Copy link

coveralls commented Dec 28, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 74.854% when pulling c40a6e5 on phil-morrell-hmlr:datasource-absent into d9433d4 on biemond:master.

@phil-morrell-hmlr
Copy link
Author

Just a warning that because I omitted the ordering arrow, this requires either puppet v6 or default v4+ ordering=manifest.

@jairojunior jairojunior closed this Oct 1, 2019
@jairojunior jairojunior reopened this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-morrell-hmlr @coveralls @jairojunior