Relax version constraint for puppetlabs-stdlib #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dependency was bumped in #207 where we use I would recommend sticking to an older version of the module it you are blocked by some modules that do not support Puppet 8 / recent stdlib yet, and rather push these modules to be updated. |
|
IMO the correct way is to update older modules to support newer stdlib version instead. And as @smortex said, we cannot downgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR relaxes the version constraint for
puppetlabs-stdlibto>= 8.1.0so that it is easier to use the module in Puppet environments with modules that explicitly depend on< 9.This Pull Request (PR) fixes the following issues
Fixes #219