Port to FreeBSD #172
Open
Port to FreeBSD #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Jun 30, 2021
| $service_hasstatus = true | ||
| $service_restart = 'pkill -HUP telegraf' | ||
| } | ||
| 'FreeBSD' : { |
bastelfreak
reviewed
Jul 14, 2021
metadata.json
Outdated
Comment on lines
80
to
82
| "11", | ||
| "12", | ||
| "13" |
There was a problem hiding this comment.
Suggested change
| "11", | |
| "12", | |
| "13" | |
| "11", | |
| "12", | |
| "13" |
|
@rmdir can you take a look at the failing tests? |
|
I took a quick look lere. I'm not sure if you want to instal telegraf via an archive or package so I won't be able to adjust the tests accordingly. |
|
I fixed the tab issue |
|
On FreeBSD there is a grate package package { 'telegraf': } just works |
|
@rmdir can you take a look at the failing tests? |
|
Dear @rmdir, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR contains some code that makes puppet-teletgraf works with FreeBSD