Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default external_labels #627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update default external_labels #627

wants to merge 1 commit into from

Conversation

wilfriedroset
Copy link

Pull Request (PR) description

The following commit sets external_labels to an empty hash by default. The previous value prevent the use of deep-merge strategy for the key prometheus::global_config when using hiera.

⚠️ This might be a breaking change for some users

This Pull Request (PR) fixes the following issues

None

@wilfriedroset
Update default external_labels
8633b66 
The following commit sets `external_labels` to an empty hash by default.
The previous value prevent the use of deep-merge strategy for the key
`prometheus::global_config` when using hiera.

Signed-off-by: Wilfried Roset <wilfriedroset@users.noreply.github.com>
@bastelfreak
Copy link
Member

Thanks for the PR. I would like to keep this open until we've a few breaking changes and can relase all of them in a new major release.

@wilfriedroset
Copy link
Author

@bastelfreak any chance to get this merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wilfriedroset @bastelfreak