-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Snapshot Repository #1087
Open
jtbrush56
wants to merge
7
commits into
voxpupuli:master
Choose a base branch
from
jtbrush56:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+80
−6
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
032c581
adds code for azure snapshot repository
d17608e
adds optional fields to body.
0686a7f
removes container default name
66b3703
removes trailing whitespace
d40328d
adds comment for mandatory params
ac38657
cleans up alignment
7a4a933
adds example to readme
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,8 +36,23 @@ | |
# @param repository_type | ||
# Snapshot repository type. | ||
# | ||
# @param location | ||
# Location of snapshots. Mandatory | ||
# @param location. Mandatory for type => "fs" | ||
# Location of snapshots. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This field is still mandatory when |
||
# | ||
# @param container. Mandatory for type => "azure" | ||
# Azure Container name. | ||
# | ||
# @param client | ||
# Azure named client to use. | ||
# | ||
# @param base_path | ||
# Azure path within container to repository data. | ||
# | ||
# @param readonly | ||
# Makes Azure repository read-only. | ||
# | ||
# @param location_mode | ||
# Azure location_mode. | ||
# | ||
# @param compress | ||
# Compress the snapshot metadata files? | ||
|
@@ -60,8 +75,13 @@ | |
# @author Tyler Langlois <tyler.langlois@elastic.co> | ||
# | ||
define elasticsearch::snapshot_repository ( | ||
String $location, | ||
Optional[String] $location = undef, | ||
Enum['absent', 'present'] $ensure = 'present', | ||
Optional[String] $client = undef, | ||
Optional[String] $container = undef, | ||
Optional[String] $base_path = undef, | ||
Optional[Boolean] $readonly = false, | ||
Optional[String] $location_mode = undef, | ||
Optional[String] $api_basic_auth_password = $elasticsearch::api_basic_auth_password, | ||
Optional[String] $api_basic_auth_username = $elasticsearch::api_basic_auth_username, | ||
Optional[Stdlib::Absolutepath] $api_ca_file = $elasticsearch::api_ca_file, | ||
|
@@ -88,6 +108,7 @@ | |
chunk_size => $chunk_size, | ||
compress => $compress, | ||
location => $location, | ||
location => $location, | ||
max_restore_rate => $max_restore_rate, | ||
max_snapshot_rate => $max_snapshot_rate, | ||
type => $repository_type, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These new fields will need to be added as
optional
fields on thegenerate_body
method below.