Use one operating system for most RSpec tests #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of Puppet classes and defined types in this module do not have behaviour which changes depending on the operating system. Mock one operating system for most tests, except for collectd_init_spec when mocking multiple operating systems makes sense. This attempts to address #633 , and should reduce test runtimes considerably with little change in the confidence of tests actually picking up problems.
juniorsysadmin
force-pushed
the
chop-matrix
branch
from
0d3f7bb
to
8517b1d
Compare
bastelfreak
approved these changes
Mar 31, 2018
|
I"m fine with this but we should wait with merging to get a bit feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of Puppet classes and defined types in this module do not
have behaviour which changes depending on the operating system. Mock one
operating system for most tests, except for collectd_init_spec when
mocking multiple operating systems makes sense.
This attempts to address #633 , and should reduce test runtimes
considerably with little change in the confidence of tests actually
picking up problems.