Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up ability for anyone to import comments on bills & petitions #187

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

dallasjc
Copy link
Contributor

@dallasjc dallasjc commented Oct 4, 2019

This is specced out here: https://docs.google.com/document/d/10dxwWM1umbHoyhUk-0QHfwCvvRIxufYh7a-5qSvWbdY/edit

This pr cannot be finished until https://github.com/voteliquid/api.liquid.us/pull/97 is approved
This pr is required for the following prs:
#188
#189
https://github.com/voteliquid/api.liquid.us/pull/98

There are three main changes:
make it possible for anyone to import comments
make page friendlier for users
link petition page to import-vote-page

  • Fix Import argument button on bill page
    This happens when page isn’t full-size and isn’t small enough for them to all to be on their own line

image

  Can’t figure out how to fix this, tried switching to columns with no luck

Modify import-vote-page language
image

  • Move explanation from comment box to top of page

  • Modify title language

  • modify bill link to show title instead of short_id
    I've set up a function that does this by fetching the measure and loading cookies. It works, unless you go to the bill page and type import rather than press the import button - for some reason the cookies don't refresh

  • make import argument page available for all users.

  • add new text for logged out users

  • make import argument button functional for all users

  • redirect to join page when logged out

  • Set approval_status to undefined when adding to backend

  • add Import comment button to petition page
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant