-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up ability for anyone to import comments on bills & petitions #187
Draft
dallasjc
wants to merge
17
commits into
voteliquid:master
Choose a base branch
from
dallasjc:import-bill-comments
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is specced out here: https://docs.google.com/document/d/10dxwWM1umbHoyhUk-0QHfwCvvRIxufYh7a-5qSvWbdY/edit
This pr cannot be finished until https://github.com/voteliquid/api.liquid.us/pull/97 is approved
This pr is required for the following prs:
#188
#189
https://github.com/voteliquid/api.liquid.us/pull/98
There are three main changes:
make it possible for anyone to import comments
make page friendlier for users
link petition page to import-vote-page
This happens when page isn’t full-size and isn’t small enough for them to all to be on their own line
Modify import-vote-page language
Move explanation from comment box to top of page
Modify title language
modify bill link to show title instead of short_id
I've set up a function that does this by fetching the measure and loading cookies. It works, unless you go to the bill page and type import rather than press the import button - for some reason the cookies don't refresh
make import argument page available for all users.
add new text for logged out users
make import argument button functional for all users
redirect to join page when logged out
Set approval_status to undefined when adding to backend
add Import comment button to petition page