[Bug fix] Ignoring ssl integrity check for assets files #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @MuriloChianfa thank you for your PR! I will check this later today :) |
|
Are you using a local environment when running these checks? Did you check the paragraph "Running the scanner in a local environment"? You can already set the verification of SSL certificate to |
|
i've already setted the verification of SSL certificate to false, but seems thats missing on this step of the code, so we need to use these options to ignore the SSL certificates integrity |
Baspa
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Can you set the verify to false only when the verify in the config is also set to false? Then I can merge it @MuriloChianfa
|
Awesome, thanks! @MuriloChianfa |
Baspa
approved these changes
Sep 4, 2024
Baspa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @Baspa 👋 long time no see you, im upgrading some package versions in my project and when i've tested the new versions of laravel-seo-scanner im receiving this error:
After these changes:
This PR aims to solve this problem, can u check if its relevant for the package?