Merge branch 'transition-words-in-content' of github.com:vormkracht10…

…/laravel-seo-scanner into transition-words-in-content
vormkracht10 · Aug 17, 2023 · ae948ce · ae948ce
2 parents 94561dd + c6bddff
commit ae948ce
Showing 1 changed file with 21 additions and 20 deletions.
diff --git a/src/Checks/Content/AltTagCheck.php b/src/Checks/Content/AltTagCheck.php
@@ -39,27 +39,11 @@ public function check(Response $response, Crawler $crawler): bool
     public function validateContent(Crawler $crawler): bool
     {
         $imagesWithoutAlt = $crawler->filterXPath('//img[not(@alt)]')->each(function (Crawler $node, $i) {
-            $src = $node->attr('src');
-
-            $dimensions = $this->getImageDimensions($src, $node);
-
-            if ($dimensions['width'] < 5 || $dimensions['height'] < 5) {
-                return null;
-            }
-
-            return $src;
+            return $this->filterImage($node);
         });
-
+        
         $imagesWithEmptyAlt = $crawler->filterXPath('//img[@alt=""]')->each(function (Crawler $node, $i) {
-            $src = $node->attr('src');
-
-            $dimensions = $this->getImageDimensions($src, $node);
-
-            if ($dimensions['width'] < 5 || $dimensions['height'] < 5) {
-                return null;
-            }
-
-            return $src;
+            return $this->filterImage($node);
         });
 
         // Remove null values from the arrays
@@ -81,7 +65,24 @@ public function validateContent(Crawler $crawler): bool
         return true;
     }
 
-    public function getImageDimensions(string $src, Crawler $node): array
+    private function filterImage($node): ?string
+    {
+        $src = $node->attr('src');
+
+        if (str_contains($src, '.svg')) {
+            return $src;
+        }
+
+        $dimensions = $this->getImageDimensions($src, $node);
+
+        if ($dimensions['width'] < 5 || $dimensions['height'] < 5) {
+            return null;
+        }
+
+        return $src;
+    }
+
+    private function getImageDimensions(string $src, Crawler $node): array
     {
         if (app()->runningUnitTests()) {
             return [