Fix runtime release crash and add functionality to scene.hpp #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable changes:
I use these on my own project and thought it would be nice if roguelite had this functionality, as a base library of sorts, but
I'd understand if it were considered out of scope for the game itself, since it doesn't really require it.
There's ambiguity between the terms "resource" and "scene" throughout level.cpp's packed_scene class (a scene seems to be considered a resource in godot).
But I think referring to scenes as resources is alright.
I tested the specific additions (such as packing from instanced node and saving packed resource) on my roguelite templated project and the overall functionality and intent for it works good for me.
Of course I also tested this branch of the game in debug from VSC, and in release as windows standalone (where it now runs fine, I believe it wouldn't have run for anyone previously).
I thought of adding some tests to prove all this stuff works, but really they'd just be a useless apendage to the sample roguelite game. Can still do it if required though.