Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clusterId IE to Antrea registry #379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add clusterId IE to Antrea registry #379

wants to merge 1 commit into from

Conversation

antoninbas
Copy link
Member

As a way to identify the K8s cluster from which the IPFIX record was exported.

The IE is of type string to allow for enough flexibility. This could be a qualified name or a UUID (for example). It should uniquely identify the cluster (to an external IPFIX collector).

@antoninbas
Add clusterId IE to Antrea registry
62590a7 
As a way to identify the K8s cluster from which the IPFIX record was
exported.

The IE is of type string to allow for enough flexibility. This could be
a qualified name or a UUID (for example). It should uniquely identify
the cluster (to an external IPFIX collector).

Signed-off-by: Antonin Bas <antonin.bas@broadcom.com>
@antoninbas
Copy link
Member Author

@heanlan I was hesitating to name this "clusterUUID" and use the octetArray type. This would reduce the size of the value from 36 bytes down to 16 bytes. However, it doesn't seem like we really support octetArray in the library. Using the string type but not the typical string representation of a UUID also seems suboptimal.
I thought that a string "clusterId" field would be a bit more flexible, but I am not sure what is best. Let me know what you think.
For reference, this is the corresponding draft PR for Antrea: antrea-io/antrea#6769

heanlan
heanlan approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@heanlan heanlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heanlan
Copy link
Contributor

heanlan commented Oct 29, 2024

I thought that a string "clusterId" field would be a bit more flexible, but I am not sure what is best. Let me know what you think. For reference, this is the corresponding draft PR for Antrea: antrea-io/antrea#6769

It makes sense to me. I agree that a string type is more flexible, comparing to strict uuid type.

yuntanghsu
yuntanghsu approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@yuntanghsu yuntanghsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heanlan heanlan heanlan approved these changes

@yuntanghsu yuntanghsu yuntanghsu approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antoninbas @heanlan @yuntanghsu @vmwclabot