Use s6-overlay to handle the startup of socat and Home Assistant #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for all the work. I'll test these in the next couple of days and merge the pull request (after a quick look I don't expect any issues). |
|
@vladbabii Any update on this? |
sdwilsh
reviewed
Jun 9, 2019
| /tmp/s6-overlay.tar.gz -L \ | ||
| "https://github.com/just-containers/s6-overlay/releases/download/${OVERLAY_VERSION}/s6-overlay-${BUILD_ARCH}.tar.gz" && \ | ||
| tar xfz \ | ||
| /tmp/s6-overlay.tar.gz -C / && \ |
There was a problem hiding this comment.
It seems like the docs for s6-overly suggest using CMD instead: https://github.com/just-containers/s6-overlay#using-cmd
|
All, I am not planning to continue with this PR. If anyone else would like to make the changes and incorporate the code, please feel free. I ended up switching to use |
|
Can you share your config with usbip or point me to a guide. Thanks.
søn. 9. jun. 2019 23.33 skrev shbatm <notifications@github.com>:
… All, I am not planning to continue with this PR. If anyone else would like
to make the changes and incorporate the code, please feel free.
I ended up switching to use usbip instead of socat and found that I can
pass through my device from the host using the /dev/serial/by-id/ path
into HASS.io, therefore, this is no longer needed in my setup.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2?email_source=notifications&email_token=AAV6P7Z4JQD6XQUSCJO6C4TPZVZI5A5CNFSM4GT3RGF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXISWJA#issuecomment-500247332>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAV6P75ADWIKVTMKJRSNOWTPZVZI5ANCNFSM4GT3RGFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing some changes I made for my personal use. I made some modifications to use
s6-overlayto manage socat and HASS startup.I also modified the Dockerfile to use Alpine Linux's
apk addinstead of Ubuntu'sapt-get installsince the new Home Assistant images are based on Alpine. In addition, you can provide--build-arg BUILD_FROM=...in yourdocker buildcommand to specify the base Home Assistant image to use. For example, I use--build-arg BUILD_FROM=homeassistant/qemuarm-64-homeassistantfor my system.