Address review comments

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
vitessio · Nov 22, 2024 · 65d82f3 · 65d82f3
1 parent df0cdf8
commit 65d82f3
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/go/summarize/utils_test.go b/go/summarize/utils_test.go
@@ -17,6 +17,7 @@ limitations under the License.
 package summarize
 
 import (
+	"github.com/stretchr/testify/assert"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -48,14 +49,9 @@ func TestGetFileType(t *testing.T) {
 		t.Run(tc.filename, func(t *testing.T) {
 			ft, err := getFileType(tc.filename)
 			if tc.expectedError != "" {
-				require.Error(t, err)
-			}
-			if err != nil {
-				require.Contains(t, err.Error(), tc.expectedError)
-			}
-			if ft != tc.expectedType {
-				t.Errorf("Expected type: %v, got: %v", tc.expectedType, ft)
+				require.ErrorContains(t, err, tc.expectedError)
 			}
+			assert.Equal(t, tc.expectedType, ft)
 		})
 	}
 }