Runtime performance imporovements #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadejs
commented
Oct 17, 2013
tadejs
commented
- the resized images are not pngs, but the same format as the original image. PNG photos can get quite heavy.
- check HTTP If-Modified-Since and return 304 if the person already has the image on his computer - we can avoid re-sending it every time.
- the entire image is not loaded on every request anymore - if we have a cached version of the matching size, just render that, and don't touch the original PilImage
Return 304 if the client already has the modified file. Load the original PilImage only if it's actually needed - otherwise small thumbnails load all sorts of images.
vinyll
force-pushed
the
master
branch
2 times, most recently
from
0a17394
to
7b8b1b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.