Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chatbot 632 setting use of context values #253

Open
wants to merge 26 commits into
base: develop
Choose a base branch
from

Conversation

romaricspklee
Copy link
Contributor

No description provided.

… delete and on contextValue delete ++ update delete bot method]
cva.cva_id,
cpv.cpv_id,
cva.label as cva_label,
cpv.value as cpv_value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

À l'affichage, il me semble préférable de présenter à l'utilisateur une valeur "opérateur : valeur" plutôt que seulement la valeur.
Le champ cpv_value récupéré ici est donc pour moi à alimenter en ce sens.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'aime bien l'idée, à valider avec notre cher PO :)

cva.cva_id,
cpv.cpv_id,
cva.label as cva_label,
cpv.value as cpv_value
Copy link
Collaborator

@cmazereau cmazereau Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Même remarque que pour les ressources documentaires : il me semble préférable de récupérer une valeur "opérateur : valeur" pour le cpv_value.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem que précedemment, à valider avec le PO

<vu:include-data object="documentaryResourceTypeList" field="dreTypeCd" />
<vu:include-data object="documentaryResource" field="*" modifiable="true"/>
<vu:include-data object="documentaryResourceContextIhmList" field="*" modifiable="true"/>
<vu:include-data object="documentaryResourceTypeList" field="*" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suite à cette modifications, les 2 include-data suivants devraient pouvoir être supprimés.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, effectivement

v-model="vueData.newDocumentaryResourceContext.cpvId"
:options="[{ cpvId: null, value: '' }, ...vueData.filteredContextPossibleValueList]"
option-value="cpvId"
option-label="value"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour la valeur de contexte à sélectionner, il vaudrait mieux afficher à l'utilisateur "opérateur : valeur" plutôt que la valeur seule.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem, à valider avec le PO

fldDocumentaryResourceContextIhm$cvaId = Context value id
fldDocumentaryResourceContextIhm$cpvId = Context possible value id
fldDocumentaryResourceContextIhm$cvaLabel = Context
fldDocumentaryResourceContextIhm$cpvValue = Value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajouter également ces clés de ressources dans les fichiers d'internationalisation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, à corriger

v-model="vueData.newQuestionAnswerContext.cpvId"
:options="[{ cpvId: null, value: '' }, ...vueData.filteredContextPossibleValueList]"
option-value="cpvId"
option-label="value"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De même que pour les ressources documentaires, il vaudrait pour moi mieux afficher à l'utilisateur "opérateur : valeur".

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A valider avec le PO

fldQuestionAnswerContextIhm$cvaId = Context value id
fldQuestionAnswerContextIhm$cpvId = Context possible value id
fldQuestionAnswerContextIhm$cvaLabel = Context
fldQuestionAnswerContextIhm$cpvValue = Value
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ajouter également ces clés de ressources dans les fichiers d'internationalisation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, à corriger

chatbotProfilServices.deleteAllProfilByBot(bot);
chatbotCustomConfigServices.deleteChatbotCustomConfig(bot);
contextValueServices.deleteAllByBotId(bot.getBotId());
contextPossibleValueServices.deleteAllContextPossibleValueByBot(bot);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il me semblerait préférable que ce soit le service de suppression des contextValue (contextValueServices.deleteAllByBotId(bot)) qui s'occupe de supprimer les contextPossibleValue associées.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui, plus logique, à corriger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants