Refactored data members as const

verbio-technologies · Mar 26, 2024 · 7f73bc2 · 7f73bc2
1 parent 032a996
commit 7f73bc2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/headers/Grammar.h b/headers/Grammar.h
@@ -26,8 +26,8 @@ class Grammar {
     std::vector<char> getCompiledBytes() const;
 
 private:
-    GrammarType type;
-    std::string content;
+    const GrammarType type;
+    const std::string content;
     std::vector<char> compiledBytes;
 };
 

diff --git a/src/Grammar.cpp b/src/Grammar.cpp
@@ -1,20 +1,12 @@
 #include "Grammar.h"
 #include <fstream>
 
-Grammar::Grammar() {
-    type = NONE;
-    content = "";
-}
-
-Grammar::Grammar(const GrammarType type, const std::string content) {
-    this->type = type;
-    this->content = content;
+Grammar::Grammar() : type{NONE}, content{} {}
 
+Grammar::Grammar(const GrammarType type, const std::string content) : type(type), content(content) {
     if (type == COMPILED) {
         std::ifstream input(content, std::ios::binary);
-
         compiledBytes = {content.data(), content.data() + content.length()};
-
         input.close();
     }
 }