Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added segment all button and mask rendering #524

Closed
wants to merge 9 commits into from

Conversation

mimithecoconut
Copy link

This adds a Segment-SAM tab with an Segment All button and the corresponding mask rendering connections. Clicking Segment All should segment according to the given mask. Also, modifies processing for npy file which had a bug before. Disables immediate segmentation loading but segmentation can be shown by using Segment All button.

@ykevu
Copy link
Collaborator

ykevu commented Oct 4, 2023

Out of curiosity, is there a specific reason the SAM button needs to be on its own tab?

@mimithecoconut
Copy link
Author

Out of curiosity, is there a specific reason the SAM button needs to be on its own tab?

Because there are going to be additional SAM actions to add in the tab and also Dave said to put it in a separate tab.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately it looks like this PR has the "windows vs unix line-endings" issue that prevents it from really being reviewable. I'll take a stab at that when I get a chance but @mimithecoconut it might be worth reviewing your editor configuration again! FWIW the thing that we really need is that diffs only reflect the actual changes rather than a re-writing of every file that was opened!

@mimithecoconut
Copy link
Author

Unfortunately it looks like this PR has the "windows vs unix line-endings" issue that prevents it from really being reviewable. I'll take a stab at that when I get a chance but @mimithecoconut it might be worth reviewing your editor configuration again! FWIW the thing that we really need is that diffs only reflect the actual changes rather than a re-writing of every file that was opened!

Yeah I realized that two of the files got completely all modified due to that. Trying to fix it. Also I saw issue with test and trying to figure out why the backend tests don't pass.

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and close this one for now in favor of #530 - thanks @mimithecoconut !

@rossbar rossbar closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants