Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gimme maelstrom #869

Merged
merged 119 commits into from
Jun 17, 2022
Merged

Gimme maelstrom #869

merged 119 commits into from
Jun 17, 2022

Conversation

Maarten-vd-Sande
Copy link
Member

@Maarten-vd-Sande Maarten-vd-Sande commented May 25, 2022

What problem is the PR solving / What's new?

  • Gimme maelstrom can now be run!
    • Makes a motif2factors if necessary
    • embeds the maelstrom report in the gimme report
  • a technical_reps and biolical_reps count table is being made. The bioloigical reps one is the mean of the reps belonging to it.

Checklist

  • I made a PR to develop (not master)
  • If applicable: I updated the docs
  • I updated the CHANGELOG
  • These changes are covered by the tests

@Maarten-vd-Sande Maarten-vd-Sande marked this pull request as ready for review June 14, 2022 13:05
Copy link
Member

@siebrenf siebrenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, at least the dense_samples() addition is needed to make it robust.

seq2science/util.py Outdated Show resolved Hide resolved
seq2science/rules/motif_scan.smk Outdated Show resolved Hide resolved
seq2science/rules/motif_scan.smk Outdated Show resolved Hide resolved
seq2science/rules/motif_scan.smk Outdated Show resolved Hide resolved
counts = pd.read_table(snakemake.input[0], comment="#", index_col=0)
samples = pd.read_table(StringIO(snakemake.params.samples), sep="\s+")
breps = snakemake.params.breps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will parse the samples file the same way (if the descriptive_name column is sparse, it will use replicate/sample names):

from seq2science.utils import dense_samples

samples = dense_samples(samples, config)

seq2science/scripts/maelstrom_report.py Show resolved Hide resolved
@Maarten-vd-Sande Maarten-vd-Sande merged commit d3741e1 into develop Jun 17, 2022
@Maarten-vd-Sande Maarten-vd-Sande deleted the gimme_maelstrom branch June 17, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants