Feat (deploy): Port localhost deployment code #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OjusWiZard
force-pushed
the
feat/non-docker
branch
3 times, most recently
from
9604d73
to
9854546
Compare
8ball030
reviewed
Sep 26, 2024
| @@ -154,7 +154,7 @@ def __init__(self, logger: logging.Logger, dump_dir: Optional[Path] = None) -> N | |||
|
|
|||
| self.resets = 0 | |||
| self.logger = logger | |||
| self.dump_dir = dump_dir or Path("/tm_state") | |||
| self.dump_dir = dump_dir or Path(os.environ["TMSTATE"] or "/tm_state") | |||
There was a problem hiding this comment.
Can we add this to the docs somewhere btw?
Also would be nice to able to set an alias for the agent.
It's in aea fetch AGENT --alias command group
There was a problem hiding this comment.
Sure! do you know any good place to add the docs? I'm guessing the docstring of def create_server()?
OjusWiZard
force-pushed
the
feat/non-docker
branch
from
9854546
to
8e9a19b
Compare
Adamantios
reviewed
Sep 27, 2024
OjusWiZard
force-pushed
the
feat/non-docker
branch
6 times, most recently
from
3c1f5aa
to
2d752cf
Compare
OjusWiZard
changed the title
OjusWiZard
force-pushed
the
feat/non-docker
branch
10 times, most recently
from
ef6e9ed
to
11e525f
Compare
Adamantios
previously approved these changes
Nov 14, 2024
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
Signed-off-by: OjusWiZard <ojuswimail@gmail.com>
OjusWiZard
force-pushed
the
feat/non-docker
branch
from
a399f62
to
325972c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Porting the code from Pearl to here that runs an agent on local host system without docker.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
xin the box that appliesChecklist
Put an
xin the boxes that apply.mainbranch (left side). Also you should start your branch off ourmain.Further comments