Add enriched wallet info endpoint #496
Open
+106
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmoreira-valory
commented
Nov 22, 2024
|
|
||
| owner_sets = set() | ||
| for chain, safe in self.safes.items(): | ||
| ledger_api = self.ledger_api(chain=chain, rpc=rpc) |
There was a problem hiding this comment.
Remove rpc? Can't be passed to a @property.
|
nice! |
truemiller
approved these changes
Nov 22, 2024
jmoreira-valory
commented
Nov 22, 2024
jmoreira-valory
commented
Nov 22, 2024
| @@ -145,6 +145,12 @@ def update_backup_owner( | |||
| """Update backup owner.""" | |||
| raise NotImplementedError() | |||
|
|
|||
| # TODO move to resource.py ? | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add enriched wallet info endpoint with owners per safe and related booleans addresed to frontend.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply