feat: refactor onboarding #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ID for contract details link
… for master safe and balance checks
…oved error handling and user feedback
truemiller
reviewed
Nov 21, 2024
Comment on lines
65
to
67
| const master = masterSafes.find( | ||
| (safe) => safe.owner === WalletOwnerType.Master, | ||
| ); |
There was a problem hiding this comment.
masterSafes is pre-filtered
Suggested change
| const master = masterSafes.find( | |
| (safe) => safe.owner === WalletOwnerType.Master, | |
| ); | |
| const master = masterSafes[0]; |
truemiller
reviewed
Nov 21, 2024
Co-authored-by: Josh Miller <31908788+truemiller@users.noreply.github.com>
truemiller
reviewed
Nov 21, 2024
| }, | ||
| }; | ||
|
|
||
| export const SetupEoaFunding = () => { | ||
| const { goto } = useSetup(); | ||
| const { masterEoaAddress } = useWallet(); | ||
| const { masterEoa } = useMasterWalletContext(); | ||
| const { walletBalances } = useBalanceContext(); |
There was a problem hiding this comment.
can get masterWalletBalances from useMasterBalances()
not a major issue for now though, this works fine
There was a problem hiding this comment.
nice, updated :)
truemiller
reviewed
Nov 21, 2024
truemiller
reviewed
Nov 21, 2024
Co-authored-by: Josh Miller <31908788+truemiller@users.noreply.github.com>
Co-authored-by: Josh Miller <31908788+truemiller@users.noreply.github.com>
truemiller
reviewed
Nov 21, 2024
| @@ -24,14 +25,18 @@ export const MECHS: Mechs = { | |||
| name: 'Agent Mech', | |||
| contract: new MulticallContract( | |||
| '0x77af31De935740567Cf4fF1986D04B2c964A786a', | |||
| AGENT_MECH_ABI, | |||
| AGENT_MECH_ABI.filter( | |||
There was a problem hiding this comment.
probably better to put on the ABI itself, but this is fine for now; no need for JsonFragment either, can use Abi from types
no 100%, but i don't think we'll ever need types like constructor, or event, for example 🤔
| @@ -225,6 +234,12 @@ export const SetupEoaFunding = () => { | |||
| goto(SetupScreen.SetupCreateSafe); | |||
| }, 5000); | |||
|
|
|||
| const eoaBalance = walletBalances.find((e) => e.isNative); | |||
There was a problem hiding this comment.
should we check here chainId as well? like the currentChain or maybe even homeChainId from selectedAgentConfig?
- probably can use useMasterBalances instead
truemiller
reviewed
Nov 21, 2024
…y-xyz/olas-operate-app into mohan/refactor-onboarding
Tanya-atatakai
approved these changes
Nov 21, 2024
truemiller
approved these changes
Nov 21, 2024
mohandast52
merged commit 4c80e72
into
refactor/multi-chain-support-frontend
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
(The app is running after commenting out a lot of code.)
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply