Tanya/needs funds main #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tanya-atatakai
changed the base branch from
main
to
refactor/multi-chain-support-frontend
Tanya-atatakai
commented
Nov 21, 2024
| ].stakingRequirements.OLAS; | ||
| STAKING_PROGRAMS[+chainId]?.[stakingProgramId]?.stakingRequirements?.[ | ||
| TokenSymbol.OLAS | ||
| ] || 0; |
There was a problem hiding this comment.
had to add || 0 here b/c we map on serviceTemplate.configurations which for optimus will contain three chains, but we'll have stakingRequirements in STAKING_PROGRAM only for one chain leading to undefined on others.
maybe makes sense to reconsider the serviceFundRequirements logic, we need native tokens on different chains, but olas for staking only on one. but at the moment this approach feels the most logical
truemiller
approved these changes
Nov 21, 2024
mohandast52
approved these changes
Nov 21, 2024
Tanya-atatakai
merged commit 96cafe0
into
refactor/multi-chain-support-frontend
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
hasEnoughOlasForInitialFundingto support new masterSafeBalancesserviceFundRequirementsto avoid repeating codeTypes of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply