Hooks refactors 1 #472
Merged
Hooks refactors 1 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, EOA, and safes
…tor useNeedsFunds for improved balance handling
truemiller
changed the base branch from
refactor/multi-chain-support-frontend
to
refactor/review-all-contexts
mohandast52
approved these changes
Nov 21, 2024
| safeAddress: safe.address, | ||
| contractCall: new MulticallContract( | ||
| safe.address, | ||
| GNOSIS_SAFE_ABI, |
There was a problem hiding this comment.
should base on service selected home chain id?
There was a problem hiding this comment.
the contracts don't have an assigned chainId in the multicall package, they're processed via chain specific provider in step 2
Tanya-atatakai
approved these changes
Nov 21, 2024
| () => (safeBalance?.ETH || 0) >= (serviceFundRequirements?.eth || 0), | ||
| [serviceFundRequirements?.eth, safeBalance], | ||
| () => { | ||
| if (!serviceFundRequirements) return ; |
There was a problem hiding this comment.
also small, but I noticed in needsInitialFunding you return false in similar cases, but here undefined;
for type safety and consistency, maybe you could specify the return type? might help prevent surprises
const hasEnoughEthForInitialFunding: boolean = useMemo(
There was a problem hiding this comment.
yeah, i agree, however, boolean hides that the value is not yet loaded..
i.e. if it's true/false we can't assume that a new value is coming, or it is not yet defined due to awaiting some promise
truemiller
commented
Nov 21, 2024
truemiller
changed the base branch from
refactor/review-all-contexts
to
refactor/multi-chain-support-frontend
…ntend' into refactor/hooks
truemiller
merged commit c3c01f2
into
refactor/multi-chain-support-frontend
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Refactor hooks to support updated contexts
About half way through ~
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply