Context checks, remove master safe context, few component integrations #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of serviceStatus
…for wallet management
…roved wallet management
truemiller
changed the title
mohandast52
approved these changes
Nov 21, 2024
| address: wallet.address, | ||
| link: { | ||
| title: 'Go to Safe', | ||
| href: `${EXPLORER_URL[MiddlewareChain.OPTIMISM]}/address/${wallet.address}`, |
There was a problem hiding this comment.
TODO: chain independent
| address: address, | ||
| truncatedAddress: address ? truncateAddress(address) : '', | ||
| }); | ||
| const getBalanceData = (walletBalances: WalletBalanceResult[]) => { |
There was a problem hiding this comment.
Maybe? The "data" seems to return a singular value rather than an object.
Suggested change
| const getBalanceData = (walletBalances: WalletBalanceResult[]) => { | |
| const getBalanceDetails = (walletBalances: WalletBalanceResult[]) => { |
There was a problem hiding this comment.
this is removed/renamed in follow up PR
Tanya-atatakai
approved these changes
Nov 21, 2024
truemiller
merged commit 7b829d7
into
refactor/multi-chain-support-frontend
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
ensure contexts don't have lint errors
WalletProvidertoMasterWalletProvider(poor naming previously)some hook updates
useMasterSafe,MasterSafeContext, andGnosisSafeService, replaced withuseMultisighookfew component integrations/fixes (limited this to stop too much scope creep of PR)
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply