Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup owner update (for multi-service refactor branch) #470

Conversation

jmoreira-valory
Copy link
Collaborator

@jmoreira-valory jmoreira-valory commented Nov 20, 2024

Proposed changes

Backup owner update (for multi-service refactor branch).

Note:
After some discussions with @truemiller and @iasonrovis, it was decided to simplify the endpoint, so that the client must provide explicitly the chain and (optionally) the backup owner. No multiple chains can be specified in a single call.

The reason for that is that:

  • This will allow the frontend to monitor progress when several chains need to be changed (if we make all changes in a single call, the middleware can't provide progress information).
  • It allows to fine-tune the process of selecting which chains need to be updated. For example, if a GUI where the user ticks the boxes of the chains they want to update.
  • It avoids the problem of sending multiple chain updates with the same backup owner address where this may create conflicts (for example, we can't set the same backup owner for EVM and Solana chains).

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

api.md Outdated Show resolved Hide resolved
api.md Outdated Show resolved Hide resolved
operate/cli.py Outdated Show resolved Hide resolved
api.md Outdated Show resolved Hide resolved
@jmoreira-valory jmoreira-valory merged commit 12c331c into feat/allow-multiple-services-middleware Nov 22, 2024
4 of 5 checks passed
@jmoreira-valory jmoreira-valory deleted the feat/swap_owner_multi_chain branch November 22, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants