Add more chains #258
Draft
Add more chains #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kupermind
reviewed
Aug 2, 2024
| "service_registry": "0x48b6af7B12C71f09e2fC8aF4855De4Ff54e775cA", | ||
| "service_registry_token_utility": "0x3Fb926116D454b95c669B6Bf2E7c3bad8d19affA", | ||
| "service_manager": "0x2EA682121f815FBcF86EA3F3CaFdd5d67F2dB143", | ||
| "gnosis_safe_proxy_factory": "0x46C0D07F55d4F9B5Eed2Fc9680B5953e5fd7b461", |
There was a problem hiding this comment.
Not sure it's a good name choice. I would call it gnosis_safe_multisig, to be consistent with names in the configuration. proxy_factory can be then confused with the staking proxy factory, for example.
There was a problem hiding this comment.
I agree, it's not an ideal choice. However, refactoring the original codebase would be necessary to address this, and I decided to focus on making minimal changes to facilitate adding chains more efficiently on this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.