Feat/check trader versions #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| exit 0 | ||
| fi | ||
|
|
||
| echo "Checking out matching trader versions. In case you want to skip this check add 'test' to the tag name. Ex. v0.1.0-rc50test" |
There was a problem hiding this comment.
Is this tag naming approved by @truemiller ?
There was a problem hiding this comment.
i believe this tag will break the cli's release process..
i think it's more strict than on javascript side. Yuri had tested v0.1.0-rcX.Y last week, and it required a full bump for major.minor.patch instead..
however, we could adopt a more robust versioning approach here, and use dev tags for tests moving forward, as we're currently just spamming rc versions
see: https://peps.python.org/pep-0440/#public-version-identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for checking if the trader versions match during a release.